search

ArtSabintsev / Siren

Notify users when a new version of your app is available and prompt them to upgrade.
http://sabintsev.com/
MIT License
4.26k stars 407 forks source link

feat: added cache busting parameter to itunes request url #415

Closed bbialas closed 1 year ago

bbialas commented 1 year ago

Fix for the issue reported here: https://github.com/ArtSabintsev/Siren/issues/413

ArtSabintsev commented 1 year ago

Thanks - I'll test it in the next week or so.

ArtSabintsev commented 1 year ago

hi, do you have documentation on the t parameter being a valid parameter on the lookup API?

Thanks!

bbialas commented 1 year ago

Hi, no, there is no official documentation on that, but there is also no documentation on what kind of cache they apply to the request.

Looks like they do not block any extra params, and timestamp in URL is a pretty common cache-busting technique.

ArtSabintsev commented 1 year ago

right, but there's no way to prove this is actually a solution.

bbialas commented 1 year ago

Hey, so what do we do with this change?

ArtSabintsev commented 1 year ago

I don't believe there's a path forward because there is no way to prove that this actually works. I think I'm going to close this pool request, and you can use this on your own branch.