ArtVentureX / sd-webui-agent-scheduler

619 stars 63 forks source link

agent-scheduler changes global CSS to bad values #123

Closed vladmandic closed 1 year ago

vladmandic commented 1 year ago

i've just noticed that some bad values in css are set by agent-scheduler. for example there are several tags such as:

@media (min-width: 1280px)
.container {
    max-width: 1280px;
}

but .container is not a private class of agent-scheduler, its a GLOBAL class. no extension should change global class - this is very bad and considered hostile!

if agent scheduler wants to have media tags, that's totally fine - just make sure its using private classes (e.g. prepent all class names uses by agent scheduler with as- or something like that.

artventuredev commented 1 year ago

Sorry about that. This class is included by default in tailwind css, should be removed on the last commit.

vladmandic commented 1 year ago

closing as resolved, thanks