Closed afbagwell closed 10 months ago
Can you share a screen capture of the button? I don't remember the extension provides any Save button.
From the Task History, click on a preview image to go to the image viewer
Once you are in the viewer, the fourth button from the left at the top should save the image to your assigned save directory path. But clicking it doesn't do anything.
This same image viewer is using on the text2img and img2img tabs to look at your generated output. The save button in those cases works properly.
I originally posted this issue to vladmandic, but his response was that is was an issue with the extension.
On A1111 there's no Save button in the image viewer, so I think this only available in SDNext. I'll need to take a look on how SDNext is handling this.
By the way, what behavior are you expecting when you click the Save
button in the task history review? The images should have already been saved to the disk.
True, however the practical use of the save button is to re-save an image you want to keep by placing another copy in a specific folder defined by the setting:
"Image Naming & Paths" -> "Directory for saving images using the Save button"
I use this all the time if I generate say 50 images, flip though them hitting the save button on the few I think are worthwhile to keep. Then I can delete everything in the original generation folder. Otherwise I would to use some other app like MS Photos or IrfanView to cycle though the images and delete everything I didn't want while keeping the few I did, which is way more tedious.
It's also a bit confusing that the same image viewer window is used for txt2img, img2img and Agent Scheduler but the save button doesn't work in the latter. If you use it in the other two, here's an example of the console output:
I understand your point. The original implementation functions only when you're on one of the three main tabs (Text, Image, Process), where additional Save buttons are present in the generation result area. Eg:
To implement this, I'll need to add an extra Save button to the agent scheduler tab. Given that this isn't a critical issue, I plan to address it next weekend, as my current workload from my day job is quite substantial.
@afbagwell The save function is added on the latest update. You can give it a try.
This applies to SDNext/vladmandic. I don't know if A1111 is affected.
The save button inside the viewer instance provided by the Agent Scheduler doesn't work.
I verified that none of the images saved this way actual get copied to the destination. No "Copying image: ..." output in the console.
If you use the image viewer from the "From Text" tab in SDNext the save button works as expected.