search

ArtVentureX / sd-webui-agent-scheduler

634 stars 67 forks source link

Support Numpy Array and Tensor serialization / deserialization (Fully support ControlNet) #68

Closed aria1th closed 1 year ago

aria1th commented 1 year ago

Supports gr.Image(type="numpy") type handlers.

Tested with https://github.com/aria1th/stable-diffusion-webui-two-shot and controlNet, works properly.

aria1th commented 1 year ago

Controlnet has bug, and can be solved by https://github.com/Mikubill/sd-webui-controlnet/pull/1778

artventuredev commented 1 year ago

Hello @aria1th, thank you for submitting this PR! Overall, it looks really good. I have left some minor comments on the code, but once those are addressed, it should be ready to merge.

aria1th commented 1 year ago

@artventuredev Thanks for the review! I just tested with requested changes. It works for both API and UI side scheduling! (but please don't forget to check if I've done stupid stuff too)

artventuredev commented 1 year ago

Hi @aria1th, I added a few more comments that I missed yesterday.

aria1th commented 1 year ago

@artventuredev Thanks for new review! By the way, I found some typing problems (may cause compatibility error for previous python versions), I'll fix it together in this patch!

aria1th commented 1 year ago

@artventuredev All test is finished!

artventuredev commented 1 year ago

Thanks a lot. The PR is merged.