search

Artea-Station / Artea-Station-Server

A HRP server focused on a cohesive setting with neat features.
https://discord.gg/BrwHEt8Hdc
GNU Affero General Public License v3.0
4 stars 17 forks source link

[Port] More cool visuals for ballistics #520

Closed QuacksQ closed 10 months ago

QuacksQ commented 11 months ago

About The Pull Request

Holy shit this is cool as fuck please merge this 🙏 builds on #455 and #460.

This PR adds a buncha cool particle effects for ballistic guns and new explosion visuals because the old ones suck. Code and everything is originally from TGMC so this is a port of the following PR's:

Code was borrowed from a Mojave Sun PR because I dont know how to code lmao.

This looks so fucking cool combined with the movable physics on the shell casings dude. imagine how cool gunfights on the station are gonna look after this.

How Does This Help Gameplay?

It helps gameplay because it looks cool as fuck just look at it dude.

How Does This Help Roleplay?

More Immersion because it looks alot more realistic? Idk dude sue me at this point I just want cooler gun visuals and this is gonna help my immersion alot :)

Proof of Testing

Screenshots/Videos # New explosions https://github.com/Artea-Station/Artea-Station-Server/assets/79924768/3a73e457-2429-4ff6-bacb-0afaf6aab9ec # New gun visuals https://github.com/Artea-Station/Artea-Station-Server/assets/79924768/6e4ee0f3-3965-4402-8571-d950c1ea6a2d

Changelog

:cl: qol: Ballistics now emit smoke when fired and bullet impacts also have proper smoke added to them. qol: Explosions look much cooler and have many more particles to them! imageadd: Added a newer and much cooler explosion sprite (grabbed from Mojave Sun) /:cl:

QuacksQ commented 11 months ago

Don't merge this yet, explosions are scuffed rn and I need to figure out why

QuacksQ commented 11 months ago

Ready for review now

github-actions[bot] commented 10 months ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.