search

Artea-Station / Artea-Station-Server

A HRP server focused on a cohesive setting with neat features.
https://discord.gg/BrwHEt8Hdc
GNU Affero General Public License v3.0
4 stars 17 forks source link

[515 Exclusive] Moving Positional Audio! #523

Closed RimiNosha closed 9 months ago

RimiNosha commented 10 months ago

About The Pull Request

https://github.com/tgstation/tgstation/pull/79135

Not calling this a port cause this is a dead PR, and I ended up changing the core way this did stuff anyways.

So basically, this hijacks playsound (but not playsound_local, you're on your own for that), and directs it to a fancy datum that tracks when things move.

The result is positional audio that moves for clients, meaning a sound that starts on your right, will now move to the left when you move to the left of it. Advanced stuff, I know.

Known Issues:

How Does This Help Gameplay?

You can tell if you've moved past something that's making noises constantly?

Also means that I can add long-form sounds to stuff like machines without tracking issues, once we go 515 only.

Proof of Testing

Screenshots/Videos https://github.com/Artea-Station/Artea-Station-Server/assets/106692773/21262989-dee3-4101-a501-e03f933b7618

Changelog

:cl: add: Moving positional audio for 515 clients. See PR 523 for more info. /:cl:

RimiNosha commented 10 months ago

Looping sounds like the SM suffer from that repeat hard on live.

RimiNosha commented 10 months ago

Causes insane client lag when many sounds are played at once (see explosions)

github-actions[bot] commented 10 months ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

github-actions[bot] commented 10 months ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.