Artea-Station / Artea-Station-Server

A HRP server focused on a cohesive setting with neat features.
https://discord.gg/BrwHEt8Hdc
GNU Affero General Public License v3.0
4 stars 17 forks source link

[Port][Help Wanted] Spessmen anonymous (Bobnames from MS) #529

Closed QuacksQ closed 8 months ago

QuacksQ commented 10 months ago

About The Pull Request

This PR is a port of the following:

Basically what this PR does is that it changes the way that anonymity is handled. The way it does this is the following: You will no longer know the names of all the crew and everyone around you. Instead a generic bit of text about the character is displayed. So instead of John Doe You will now see old white man instead. Yes this works in the right click menu, when you examine people and even on screen tips.

"So how do we know who people are?"

Good question. Names will be displayed if a person is wearing their ID. If someone doesn't have their ID on them and you still want to know their name you'll have to ask them to figure it out. Shocker, talking to people on a Roleplaying server is now needed if you want to know their name.

This PR also adds a Guestbook that will allow you to save peoples names after you learn them. Input for adding names to the Guestbook is a simple text box input. The Guestbook can be opened by a verb in the IC tab and will display a list of the names you know. You can use CTRL+SHIFT+LMB on people to add them to your Guestbook. (This is a manual process and not automated because automating this will ruin the whole system) image

Currently it is setup so that no-one knows anyone. This can be changed so people with the same job or department will know one-another. I would much rather see the system be persistent and save names between different rounds though so people can build lasting characters with their own networks and circles.

Future wish-list and or todo list (I need help because Idk how to code this)

How Does This Help Gameplay?

No real gameplay changes here because this is for roleplay.

How Does This Help Roleplay?

image

You will actually have to talk to people now to know their names!!! 😱

Great roleplay potential because exchanging names is now something valuable. Opens up the opportunity for lying too when you give people a fake name instead of your real one.

Proof of Testing

Screenshots/Videos https://github.com/Artea-Station/Artea-Station-Server/assets/79924768/64ff33a7-9857-4c2b-b52d-3086bfbb6abd

Changelog

:cl: refactor: You now have to talk to people to figure out their names /:cl:

RimiNosha commented 10 months ago

Drafted while I deal with other things first. I'll get this properly reviewed by next Saturday though.

github-actions[bot] commented 10 months ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

github-actions[bot] commented 9 months ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

github-actions[bot] commented 9 months ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

github-actions[bot] commented 8 months ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.