search

Artea-Station / Artea-Station-Server

A HRP server focused on a cohesive setting with neat features.
https://discord.gg/BrwHEt8Hdc
GNU Affero General Public License v3.0
4 stars 17 forks source link

[PORT] The recoilening #589

Closed QuacksQ closed 1 month ago

QuacksQ commented 6 months ago

About The Pull Request

This pr is a port of:

This PR significantly improves recoil (screenshake when shooting guns) because our current recoil sucks ass. Instead of a simple screenshake its now based on the direction you're shooting in. I have also gone ahead and added recoil values to the guns we have in-game right now.

Ballistic guns have a recoil value of 1 Energy guns have a recoil value of 0.2 Disablers and the Miniature energy gun have a recoil value of because they're tiny 0.1

This is yet another expansion of the guns and other cool shit pr's like: #520 #455 and #460.

How Does This Help Gameplay?

Feedback to in game actions is always good and guns not having recoil when being shot is just weird.

How Does This Help Roleplay?

Immersion probably

Proof of Testing

Screenshots/Videos ## Old Recoil https://github.com/Artea-Station/Artea-Station-Server/assets/79924768/3a483a6d-a98f-4ae7-a34e-f4b7750ac7c1 ## New Recoil https://github.com/Artea-Station/Artea-Station-Server/assets/79924768/6bcefbc4-3070-44f6-90ba-45638c99b553 ## New recoil on a disabler https://github.com/Artea-Station/Artea-Station-Server/assets/79924768/7ac9e71a-eebb-4be8-afc3-a971c3d2d013

Changelog

:cl: qol: Recoil is alot less awful now and is based on the direction you're shooting in. /:cl:

github-actions[bot] commented 5 months ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

QuacksQ commented 5 months ago

Fuck you dont stale my shit

github-actions[bot] commented 5 months ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

github-actions[bot] commented 5 months ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

github-actions[bot] commented 4 months ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

ChungusGamer666 commented 4 months ago

i did this on efn too, look at my implementation perhaps and see if ita better or worse idk

github-actions[bot] commented 4 months ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.