search

Artelia / PostTelemac

Plugin for QGIS to manage Telemac results
18 stars 8 forks source link

Fix for Qgis3 #17

Closed nicogodet closed 4 years ago

nicogodet commented 4 years ago

Hi,

Few fixes and PostTelemac works well on Qgis 12.3

Api breaks : https://github.com/qgis/QGIS/blob/master/doc/api_break.dox

nicogodet commented 4 years ago

Could fix #14

patricev commented 4 years ago

Hi thank you for your work ! Tell me when you're ok and i'll push it on master branch Regards,

nicogodet commented 4 years ago

Hello, For sure, those fixes break PostTelemac en Qgis2. I (we ?) need to had check for qgis version as it was already done for some algorithms : https://github.com/Artelia/PostTelemac/blob/master/PostTelemac/meshlayertools/toshape/posttelemac_util_extractpts.py#L44L48

But do you want PostTelemac works on Qgis 2 ?

nicogodet commented 4 years ago

Hi @patricev Well you can merge if you want.

C'est à peu près stable mais j'ai pas trop le temps ni les connaissances pour fixer les derniers petits soucis qui sont :

P.S. : J'ai mis la version minimal de Qgis à 3.0 dans metadata.txt

patricev commented 4 years ago

Thanks a lot for your work !! merging