search

Artelnics / opennn

OpenNN - Open Neural Networks Library
http://www.opennn.net
GNU Lesser General Public License v3.0
1.12k stars 354 forks source link

std::codecvt_utf8 is deprecated since C++17 #264

Open shleym2000 opened 1 year ago

shleym2000 commented 1 year ago

Code uses the templated function std::codecvt_utf8, which has an implicit template parameter std::codecvt_mode

In fact the entire header is deprecated per https://isocpp.org/files/papers/p0636r0.html :

_"P0618R0 - Deprecate  - The entire header  (which does not contain the class codecvt!) is deprecated, as are the utilities wstring_convert and wbufferconvert. These features are hard to use correctly, and there are doubts whether they are even specified correctly. Users should use dedicated text-processing libraries instead."

As the result, library can not be compiled without suppressing some compiler's errors

shleym2000 commented 1 month ago

Please, consider reviewing and merging my pull request ( https://github.com/Artelnics/opennn/pull/303 )

It solves the issue and OpenNN library would be able to advance to at least C++17 standards.