search

Artemis-RGB / Artemis.Plugins

Repository containing official Artemis plugins
Other
31 stars 36 forks source link

DMX plugin keepalive (For WLED) #156

Closed Cheerpipe closed 1 year ago

Cheerpipe commented 1 year ago

This PR adds an option to set a keepalive signal to avoid devices like WLED enter into timeout/disconnected state when using solid color layers.

DarthAffe commented 1 year ago

I'm honestly not a fan of having this as such a global thing (you're forcing flushes on all devices like this). To allow a more low-level fix I've abstracted the steelseries solution for heartbeats into core,. That way you can just set the timer in the dmx device-definition. (https://github.com/DarthAffe/RGB.NET/pull/275/files)

And a second thing out of interest: Why are you using that huge intents in xaml? Oo

Cheerpipe commented 1 year ago

I'm honestly not a fan of having this as such a global thing (you're forcing flushes on all devices like this). To allow a more low-level fix I've abstracted the steelseries solution for heartbeats into core,. That way you can just set the timer in the dmx device-definition. (https://github.com/DarthAffe/RGB.NET/pull/275/files)

And a second thing out of interest: Why are you using that huge intents in xaml? Oo

This is a lot better solution. Thanks.

I didn't know my PR was updating all devices and not only DMX.

So, ¿Should I wait for another RGB.NET release?

DarthAffe commented 1 year ago

I want to test it a bit (at least the steel-series part, can't really test the dmx one) and will merge it later.