search

Artemis-RGB / Artemis.Plugins

Repository containing official Artemis plugins
Other
30 stars 38 forks source link

Corsair - K70 ANSI layout #178

Closed DragRedSim closed 1 year ago

DragRedSim commented 1 year ago

This keyboard has an included ISO layout, but not the matching ANSI variant. This PR is an attempt to rectify that.

I also corrected a couple of files which had names which did not describe the actual content, or spelling errors.

RobertBeekman commented 1 year ago

Thanks, also quite observative of you to spot the wrong brackets :)

DragRedSim commented 1 year ago

It’s an issue in more locations than I fixed up; it seems to be common across most of the default keyboard layouts. I didn’t replicate the changes through outside of the edited layouts to other devices, so the Corsair K-series are the only ones to have been updated in this manner; other Corsair devices, and non-Corsair devices, still use the old names. Just a note for future maintenance there. There were also a couple of key images in the ISO version that didn’t have matching sizes (eg. shift keys, pipe/backslash, Enter), so I recreated them in the correct size for ANSI by judicious use of the clone stamp in Paint.NET.