Open RobertBeekman opened 3 years ago
Looking into this at the moment. There's a few possibilities I need to account for:
None of the logitech softwares installed:
We don't do anything here.
LGS is installed:
In this case, the registry is not important. We just need to check the dll. If the aurora backup is present, restore that.
LGHUB is installed:
The Aurora wrapper patch overwrites the LGHUB default registry path. We need to detect GHUB is installed and restore its original path. The dll in the LGS folder is then irrelevant, we don't need to touch it.
Both LGS and GHUB are installed:
I'm not sure how to proceed here. Most likely the correct way to proceed is ignoring LGS is installed and just restore the original LGHUB path.
TLDR: we need to detect if the user has LGHUB and/or LGS installed first, and act according to that.
Aurora patches the Logitech SDK DLL, breaking Artemis Logitech support until the user reinstalles LGS or GHub.
We should detect and undo this as a prerequisite in the Logitech device provider. Patching takes place here https://github.com/antonpup/Aurora/blob/master/Project-Aurora/Project-Aurora/App.xaml.cs#L545
Best we keep in mind our own wrapper and not break that.