ArtemiusI / The-Artisan-s-Kitpack

11 stars 7 forks source link

Fighter, Ranger, Paladin overhaul class descriptions not updating for EET BGEE and Tutorial campaigns #28

Closed ewelsh42 closed 8 months ago

ewelsh42 commented 1 year ago

I'm installing the Kitpack on EET, and I noticed that the base Fighter, Ranger, and Paladin class descriptions aren't updated with the new text from their overhauls in the BGEE and Tutorial campaigns. All the other campaigns, including SoA, SoD, the Black Pits, etc. are fine. Individual kits are fine in all campaigns, it is only the base classes that have issues. The only thing I could figure is that, for whatever reason, BGEE and the Tutorial campaigns need BGCLATXT to be patched in addition to SODCLTXT. Adding BGCLATXT to the relevant patch sections fixed it. Diffs pasted below. I'm pretty new to WeiDU, so I'm not going to make any claims that I have a good understanding of its syntax or exactly what is going on with EET and which files are needed for what, etc.. Hope this helps! Thanks for all your frequent updates!

*** Fighter.tpa.original    2023-10-28 18:24:19.000000000 -0400
--- Fighter.tpa 2023-10-28 19:16:38.766563100 -0400
***************
*** 291,297 ****
      END
    END

! ACTION_FOR_EACH CLASSTEXT IN CLASTEXT SODCLTXT BEGIN
  ACTION_IF (FILE_EXISTS_IN_GAME ~%CLASSTEXT%.2da~) BEGIN
    COPY_EXISTING ~%CLASSTEXT%.2da~ ~override~
    COUNT_2DA_COLS cols // amount of columns
--- 291,297 ----
      END
    END

! ACTION_FOR_EACH CLASSTEXT IN CLASTEXT SODCLTXT BGCLATXT BEGIN
  ACTION_IF (FILE_EXISTS_IN_GAME ~%CLASSTEXT%.2da~) BEGIN
    COPY_EXISTING ~%CLASSTEXT%.2da~ ~override~
    COUNT_2DA_COLS cols // amount of columns
*** Ranger.tpa.original 2023-10-28 18:24:19.000000000 -0400
--- Ranger.tpa  2023-10-28 19:18:25.458917500 -0400
***************
*** 32,38 ****
  SETTRAPS    ****        AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ~
  END

! ACTION_FOR_EACH CLASSTEXT IN CLASTEXT SODCLTXT BEGIN
  ACTION_IF (FILE_EXISTS_IN_GAME ~%CLASSTEXT%.2da~) BEGIN
    COPY_EXISTING ~%CLASSTEXT%.2da~ ~override~
    COUNT_2DA_COLS cols // amount of columns
--- 32,38 ----
  SETTRAPS    ****        AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  AP_C0RNG01  ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ****        ~
  END

! ACTION_FOR_EACH CLASSTEXT IN CLASTEXT SODCLTXT BGCLATXT BEGIN
  ACTION_IF (FILE_EXISTS_IN_GAME ~%CLASSTEXT%.2da~) BEGIN
    COPY_EXISTING ~%CLASSTEXT%.2da~ ~override~
    COUNT_2DA_COLS cols // amount of columns
*** Paladin.tpa.original    2023-10-28 18:24:19.000000000 -0400
--- Paladin.tpa 2023-10-28 19:46:46.809297400 -0400
***************
*** 14,24 ****
      END
    END

! ACTION_IF (FILE_EXISTS_IN_GAME ~clastext.2da~) BEGIN
!   COPY_EXISTING ~clastext.2da~ ~override~
    COUNT_2DA_COLS cols // amount of columns
    READ_2DA_ENTRIES_NOW rows cols // read all file into memory  
!   FOR (row = 1; row < rows; ++row) BEGIN // iterate over rows
      READ_2DA_ENTRY_FORMER rows row 0 ~text~ // read column value
      PATCH_IF ~%text%~ STRING_EQUAL_CASE ~PALADIN~ BEGIN
        SET patch_row = %row%
--- 14,25 ----
      END
    END

! ACTION_FOR_EACH CLASSTEXT IN CLASTEXT SODCLTXT BGCLATXT BEGIN
! ACTION_IF (FILE_EXISTS_IN_GAME ~%CLASSTEXT%.2da~) BEGIN
!   COPY_EXISTING ~%CLASSTEXT%.2da~ ~override~
    COUNT_2DA_COLS cols // amount of columns
    READ_2DA_ENTRIES_NOW rows cols // read all file into memory  
!   FOR (row = 0; row < rows; ++row) BEGIN // iterate over rows
      READ_2DA_ENTRY_FORMER rows row 0 ~text~ // read column value
      PATCH_IF ~%text%~ STRING_EQUAL_CASE ~PALADIN~ BEGIN
        SET patch_row = %row%
***************
*** 50,55 ****
--- 51,57 ----
    END
    BUT_ONLY
    END
+   END

  DEFINE_ACTION_FUNCTION cd_new_portrait_icon
    INT_VAR string = 0
ewelsh42 commented 1 year ago

Oops, I left out the Monk revisions (I was looking through my Project Infinity components for "overhaul", forgot about "revisions"). Monks have the same issue, and the same fix:

*** MonkRevision.tpa.original   2023-10-28 18:24:19.000000000 -0400
--- MonkRevision.tpa    2023-10-28 21:02:02.342626500 -0400
***************
*** 195,201 ****

  LAF mod_monk_profs END

! ACTION_FOR_EACH CLASSTEXT IN CLASTEXT SODCLTXT BEGIN
  ACTION_IF (FILE_EXISTS_IN_GAME ~%CLASSTEXT%.2da~) BEGIN
    COPY_EXISTING ~%CLASSTEXT%.2da~ ~override~
    COUNT_2DA_COLS cols // amount of columns
--- 195,201 ----

  LAF mod_monk_profs END

! ACTION_FOR_EACH CLASSTEXT IN CLASTEXT SODCLTXT BGCLATXT BEGIN
  ACTION_IF (FILE_EXISTS_IN_GAME ~%CLASSTEXT%.2da~) BEGIN
    COPY_EXISTING ~%CLASSTEXT%.2da~ ~override~
    COUNT_2DA_COLS cols // amount of columns
arosenow commented 10 months ago

I can confirm the same error. The kits appear to get the description for the fighter, but the base class doesn't in EET