Artemystra / eclipsephase

The second edition character sheet for FoundryVTT
18 stars 17 forks source link

Players are not able to modify their pools #61

Closed herrozerro closed 11 months ago

herrozerro commented 11 months ago

Related to #54, players cannot edit their own pools.

Solution: Add a setting to the GM can toggle player control over the sheet.

Artemystra commented 11 months ago

Hey there, I‘m trying to push the last feature update till 1.0 this week and will then probably fix these two issues on my last stretch before releasing 1.0

Artemystra commented 11 months ago

Now... in order to modify pools this would lead to quiet the UI - Change which I'm not sure how to solve yet.

The main issue is, that by making the values editable I have to get rid of the "close" button that lets you close the pool spending menu.

Screenshot 2023-12-17 at 13 57 28 Screenshot 2023-12-17 at 13 57 34

Doing this might then lead to the question "how to I close the menu" - while clicking the pool again would do exactly this. My first idea was "clicking somewhere else on the sheet" but this solution never worked until now (code wise) and I think it's currently to much to revisit this solution, as it would be more like a new feature to me.

Leaves the question: How would you solve this in a maintainable manner? Any ideas?

Artemystra commented 11 months ago

Alternatively one could argue, that this menu isn't needed anymore once pools are editable manually... could be a solution. What do you think @herrozerro ?

EDIT: This again would leave you with no option to add active effects to ignore wounds & trauma temporarily... mh.

herrozerro commented 11 months ago

What if you added the pools to that menu?

Artemystra commented 11 months ago

Actually not the worst idea - what do you think about this? Screenshot 2023-12-17 at 15 50 49 Screenshot 2023-12-17 at 15 50 58

herrozerro commented 11 months ago

Love it

Artemystra commented 11 months ago

Great! Will be part of the next release, probably coming today...

Thanks for your support!