of skill icon bug

[jiangyi0923]

1.After enabling the skill icon, the game client cannot be closed normally,Will be blocked when the exit button is clicked 2.and Sometimes, the client ends the game for no reason, bug 2 It also existed in version 1.1,and bug1 is new. Maybe your image download code needs more reasonable modification

[Artenuvielle]

Can you provide an SCT log file for both of these cases. they are located at 'GW2 dir\addons\sct\sct.log'.

[jiangyi0923]

Perhaps bug 1 problem was that it ended the client without a smooth release of some memory or other ,The log is on my laptop pc, I can't provide it to you for the moment

[jiangyi0923]

bug2.zip

[Artenuvielle]

Sadly I cannot reproduce any of these issues. I also checked compatibility with other addons and everything else than dx912pxy should go well with SCT.

[Artenuvielle]

The skill icon loading function did change slightly in version 1.2-RC3. Check it out and feel free to tell me if it resolved any issues.

[jiangyi0923]

im chinese player ,maybe also the reason for these bugs,After using r3, the problem still exists. Here is the screenshot.

Perhaps, the Chinese web access to wiki is slow reason

[jiangyi0923]

and log is GW2 SCT: loading: C:\jz2\addons\sct\fonts\arcdps_font.ttf GW2 SCT: loading: C:\jz2\addons\sct\fonts\Roboto-Regular.ttf GW2 SCT: Running arcvers: 20200325.120355-323-x64 GW2 SCT: Skillicon load thread started GW2 SCT: Downloading skill icon: 10285 GW2 SCT: Downloading skill icon: 10191 GW2 SCT: Skillicon load thread stopping

[jiangyi0923]

Try to enter the game and then exit the game a few times. It's better than the first edition, but clicking the exit button still takes a few seconds

[Artenuvielle]

Yeah I guess you icon download is kinda slow from the official rendering API. If a download is still ongoing then the skill icon download thread won't stop until its current download is finished. I guess when you exit the game you'd have to wait for the current ongoing download to finish and only the game exits completely.

Maybe this does not happen when you already provide all of the available icons in the /addons/sct/icons folder. I added a folder with every icon I downloaded just a couple of days ago. icons.zip

[jiangyi0923]

It doesn't work properly. When I open the skill icon, I will exit the game in a few minutes.Can you directly localize the skill icon for the Chinese version?

[Artenuvielle]

Can you explain in more detail what you mean?

[jiangyi0923]

I mean, load images directly from the local "icon" file directory, not from the official API, or download all skill icons at once when first used,In this way, a corresponding icon configuration file can be generated, and the player can localize the configuration and customize it. Whenever the skill picture is updated, the player can download the corresponding icon file package through gihub again, or download the new icon file in one time, or share the configuration of others,How do you like it?

[jiangyi0923]

You can try to compile a version of the skill icon that loads completely from the "icon" folder. Let me test it out,Was it an API connection problem or a picture load problem or a memory leak

[jiangyi0923]

This situation of quitting the game, after opening the skill icon option, I will quit the game directly within a few minutes regardless of whether I use the skill or not, which makes me feel uneasy to share it with Chinese players. If this problem occurs frequently on my computer, can you imagine what other players will think,Perhaps the only thing you can do now is load the images localize

[jiangyi0923]

In version 1.3, even if there is a skill picture in the "icon" folder, the picture will still be downloaded once, which causes unnecessary downloading thread. There is no strange flash back half an hour after the skill icon is started, but the game will still be blocked

[Artenuvielle]

Yeah, I'll have a look into it in a couple of days.

[Enko63]

Looks like Anet's APIs are down atm too. Is there a way to use skill icons but not download new ones and they just won't show up if its not there?

[jiangyi0923]

I used this multithreaded library void for my project:

boost::thread thread_(void, pass parameter);

I hope it can help you,

[Artenuvielle]

Crashes with skill icons should be fixed in 1.3RC4