Closed martinvonk closed 1 year ago
Notebooks tests will probably fail on 02_knmi_observations.ipynb because https://geodata.nationaalgeoregister.nl/cbsgebiedsindelingen/wfs?request=GetFeature&service=WFS&version=2.0.0&typeName=cbs_gemeente_2017_gegeneraliseerd&outputFormat=json gives a 404.
I'd like to make 1 small change still because this header from fews:
<header> <type>instantaneous</type> <moduleInstanceId>pr.gw.merge</moduleInstanceId> <locationId>GW000XXX</locationId> <parameterId>GW.G</parameterId> <qualifierId>filter1</qualifierId> <timeStep unit="nonequidistant"/> <startDate date="2020-04-16" time="14:00:00"/> <endDate date="2023-01-12" time="06:00:00"/> <missVal>NaN</missVal> <stationName>station</stationName> <lat>52.00000</lat> <lon>5.00000</lon> <x>100000.0</x> <y>450000.0</y> <z>3.3</z> <units>mNAP</units> <thresholds> <highLevelThreshold id="MV_LTID" name="Maaiveld" label="Maaiveld Peilbuis" value="3.3" groupId="GW_LT" groupName="GW Level Thresholds"></highLevelThreshold> <highLevelThreshold id="BKB_LTID_1" name="Bovenkant Buis" label="Bovenkant peilbuis filter 1" value="3.779" groupId="GW_LT" groupName="GW Level Thresholds"></highLevelThreshold> </thresholds> </header
returns this meta:
{'type': 'instantaneous', 'moduleInstanceId': 'pr.gw.merge', 'parameterId': 'GW.G', 'qualifierId': 'filter1', 'timeStep': {'unit': 'nonequidistant'}, 'startDate': {'date': '2020-04-16', 'time': '14:00:00'}, 'endDate': {'date': '2023-01-12', 'time': '06:00:00'}, 'missVal': 'NaN', 'stationName': '01 Voorstraat', 'lat': '52.08173095414533', 'lon': '5.40519100690203', 'x': '156233.0', 'y': '454829.0', 'z': '3.3', 'units': 'mNAP', 'thresholds': '\n ', 'monitoring_well': 'GW000294'}
and thus the threshold is not entirely correct for the thresholds
I won't be able to fix this xml reading now. I'll make an issue and let's merge this.
Changes: