search

ArtesiaWater / hydropandas

Module for loading observation data into custom DataFrames
https://hydropandas.readthedocs.io
MIT License
51 stars 10 forks source link

add name of duplicate indices to logger output of _is_consistent check #116

Closed HMEUW closed 1 year ago

HMEUW commented 1 year ago

I added the name of duplicate indices to the logger output.

martinvonk commented 1 year ago

Hi @HMEUW,

Thanks for the PR. We have some checks in HydroPandas to make sure the code quality is up to standards. As you can see the linting check is failing on: ./hydropandas/obs_collection.py:756:89: E501 line too long (113 > 88 characters).

Maybe you can fix this? Or we can do this for you?

martinvonk commented 1 year ago

I fixed some last formatting issues: ./hydropandas/extensions/plots.py:558:1: W293 blank line contains whitespace so we can merge after the unit tests are done.