ArtesiaWater / hydropandas

Module for loading observation data into custom DataFrames
https://hydropandas.readthedocs.io
MIT License
52 stars 10 forks source link

Support Python 3.11 #128

Closed martinvonk closed 11 months ago

martinvonk commented 1 year ago

Now that Pastastore supports python 3.11 (https://github.com/pastas/pastastore/pull/93), HydroPandas should be fine as well.

martinvonk commented 11 months ago

The current issue fail on py311-ubunti seems to be with Linux installation. Maybe you can shed some light on this @dbrakenhoff ?

× python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [27 lines of output]
      Package hdf5 was not found in the pkg-config search path.
      Perhaps you should add the directory containing `hdf5.pc'
      to the PKG_CONFIG_PATH environment variable
      No package 'hdf5' found
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-install-6xopw9h7/netcdf4_61f6788baf8d4d23a17[72](https://github.com/ArtesiaWater/hydropandas/actions/runs/5597983180/jobs/10237044158?pr=128#step:5:73)c10ae8c3459/setup.py", line 419, in <module>
          _populate_hdf5_info(dirstosearch, inc_dirs, libs, lib_dirs)
        File "/tmp/pip-install-6xopw9h7/netcdf4_61f6788baf8d4d23a1[77](https://github.com/ArtesiaWater/hydropandas/actions/runs/5597983180/jobs/10237044158?pr=128#step:5:78)2c10ae8c3459/setup.py", line 360, in _populate_hdf5_info
Error:           raise ValueError('did not find HDF5 headers')
      ValueError: did not find HDF5 headers
      reading from setup.cfg...

          HDF5_DIR environment variable not set, checking some standard locations ..
      checking /home/runner/include ...
      hdf5 headers not found in /home/runner/include
      checking /usr/local/include ...
      hdf5 headers not found in /usr/local/include
      checking /sw/include ...
      hdf5 headers not found in /sw/include
      checking /opt/include ...
      hdf5 headers not found in /opt/include
      checking /opt/local/include ...
      hdf5 headers not found in /opt/local/include
      checking /usr/include ...
      hdf5 headers not found in /usr/include
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
dbrakenhoff commented 11 months ago

I can reproduce the issue locally. It has to do with the netCDF4 package being pinned at 1.5.8. Removing this version requirement I can install the package, but it was put there for a reason so we should check why that was.

dbrakenhoff commented 11 months ago

Some flake issue is now causing the test to stop. Leaving that fix to you @martinvonk :)

martinvonk commented 11 months ago

My specialty, thank you :)

martinvonk commented 11 months ago

Ty @dbrakenhoff for the help and @OnnoEbbens for the review