address figure filename in `series_per_group` #199

dbrakenhoff commented 7 months ago

Improve naming of resulting plots, following @HMEUW's suggestion.

I added an argument naming_method.

if None: use template "series_by_{by}_group_{values}.png"
if "infer_name_monitoringwell": uses last name from group to attempt inferring location code (splitting on "-" or "" and taking the first part), e.g. "PB001-001" will become "PB001.png". I kept this option because I needed it once, but I'm sure there was a workaround I could have used, but keeping it in here for now.
if str, interpret as column name in group and collect unique values from that column, e.g. if group contains a column "unique_name" with values PB001, PB002, PB003 the resulting file name will be "series_by_{by}_group_PB001-PB002-PB003.png"

Also added that the function will return axes handles if savefig=False.

dbrakenhoff commented 7 months ago

Can you replace 'NAP' in line 698 with row["unit"]?

The row["unit"] refers to the units of the time series right? And not necessarily the units of the screen depth which are usually one of m+ref, mNAP or m-mv, regardless of the units of the time series. For most online data sources we get screen levels relative to NAP, which is why it was initially hard-coded.

So what should we put there? We could default to NAP, and if someone wants something else, just copy the function to their own script and adjust it accordingly. Other options would be no units, or default to [m], or row["units"] which might be incorrect.

HMEUW commented 7 months ago

I suggest to make in an optional argument.

I recognize the situation you describe. Unit of filter levels is not noodzakelijkerwijs the same as the unit of the observations. We can think about this later. Add properties for coordinate system of x, y and z unit?

Van: Davíd Brakenhoff @.> Verzonden: Tuesday, March 26, 2024 11:39:36 AM Aan: ArtesiaWater/hydropandas @.> CC: Hendrik Meuwese @.>; Mention @.> Onderwerp: Re: [ArtesiaWater/hydropandas] address figure filename in series_per_group #199 (PR #201)

[LET OP] Deze e-mail is afkomstig van buiten onze organisatie.

Can you replace 'NAP' in line 698 with row["unit"]?

The row["unit"] refers to the units of the time series right? And not necessarily the units of the screen depth which are usually one of m+ref, mNAP or m-mv, regardless of the units of the time series. For most online data sources we get screen levels relative to NAP, which is why it was initially hard-coded.

So what should we put there? We could default to NAP, and if someone wants something else, just copy the function to their own script and adjust it accordingly. Other options would be no units, or default to [m], or row["units"] which might be incorrect.

— Reply to this email directly, view it on GitHubhttps://github.com/ArtesiaWater/hydropandas/pull/201#issuecomment-2020080954, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A353RUY7KQ2KGBDSZQGWHEDY2E65RAVCNFSM6AAAAABFHLIZ6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRQGA4DAOJVGQ. You are receiving this because you were mentioned.Message ID: @.***>

Waterschap Scheldestromen

Bezoekadressen: Kanaalweg 1 4337 PA @.,3.6206241,17.81z/data=!4m5!3m4!1s0x47c490de73c24d47:0x36a047ca6d131a76!8m2!3d51.4963835!4d3.6206268> en Kennedylaan 1 4538 AE @.,3.8263552,19.63z> Postadres: Postbus 1000, 4330 ZW Middelburg Telefoon: +31 (0) 88 246 1000 (lokaal tarief) Email: @.**@.> Website: www.scheldestromen.nlhttps://scheldestromen.nl

dbrakenhoff commented 7 months ago

I added the units keyword argument, let me know if you're good with this solution @HMEUW !

ArtesiaWater / hydropandas

address figure filename in `series_per_group` #199 #201