search

ArtesiaWater / hydropandas

Module for loading observation data into custom DataFrames
https://hydropandas.readthedocs.io
MIT License
56 stars 11 forks source link

Add tmin and tmax for knmi stations #239

Closed martinvonk closed 1 month ago

martinvonk commented 1 month ago

This pull request add the tmin, tmax data for the neerslag and meteo stations from the KNMI website.

OnnoEbbens commented 1 month ago

The dataframe with stations have mixed types for the tmin and tmax columns (bool, None and str). I want to check if the values are not False. Ruff raises an error, E712 Avoid equality comparisons to 'False'; use 'if not stations_df["tmin"]:' for false checks. The suggestion does not work because of the mixed datatypes in the column. Therefore I decided to ignore the ruff E712 error for this file.