search

ArtesiaWater / hydropandas

Module for loading observation data into custom DataFrames
https://hydropandas.readthedocs.io
MIT License
56 stars 11 forks source link

Cache in ObsCollection.from_knmi ignores start and end #24

Closed rubencalje closed 4 years ago

rubencalje commented 4 years ago

When cache=True is used in ObsCollection.from_knmi() the start and end parameter are ignored. This can cause problems when you run a script daily and need data for the last day.

OnnoEbbens commented 4 years ago

Thanks for pointing this out! I fixed it by putting the start and end parameter in the cached filename. Just to be sure I also added the fill_missing_obs parameter to the cached filename. Should work now in the dev branch.