ArtesiaWater / hydropandas

Module for loading observation data into custom DataFrames
https://hydropandas.readthedocs.io
MIT License
51 stars 11 forks source link

ObsCollection.from_knmi() returns wrong station data #41

Closed OnnoEbbens closed 2 years ago

OnnoEbbens commented 3 years ago

When I use:

from hydropandas import ObsCollection
stns = [344] #Rotterdam
oc_knmi = ObsCollection.from_knmi(stns=stns, 
                                         meteo_vars=["EV24", "RD"], 
                                         start=['2010', '2010'],
                                         end=['2015', '2015'],
                                         verbose=True)

I get a really weird result. Evaporation is from the correct station (Rotterdam) but the RD is suddenly from a different station (Tollebeek):

image

I think it has something to do with the fact that station 344 does not have 'RD' measurements, only 'RH'. Probably the combination with the fill_missing_obs = True gives this weird result.

OnnoEbbens commented 3 years ago

Meteo- and neerslagstations can have the same station number while being a different station. Meteostation Rotterdam has station number 344 and neerslagstation Tollebeek has station number 344.

OnnoEbbens commented 3 years ago

Best is to add some logic for the combined usage of 'RD' and 'RH' measurements.

OnnoEbbens commented 2 years ago

fixed by #67