search

ArtesiaWater / hydropandas

Module for loading observation data into custom DataFrames
https://hydropandas.readthedocs.io
MIT License
51 stars 10 forks source link

English as the main language #78

Closed OnnoEbbens closed 1 year ago

OnnoEbbens commented 1 year ago

We have quite a few Dutch words in the repository (bovenkant_filter, maaiveld, etc.). For consistency we should switch to English completely. Maybe we can store a translation file somewhere that we can use when you need a Dutch keyword.

OnnoEbbens commented 1 year ago

For the groundwater attributes it would be nice to use the BRO terms as they are already in English

OnnoEbbens commented 1 year ago

attributes are renamed. Last Dutch thing to get rid of is the 'stand_m_tov_nap'

OnnoEbbens commented 1 year ago

I removed all the 'stand_m_tov_nap' references. Only kept them in Dino because it is the name in the csv files. Because we lose some information about the unit and datum. I added the 'unit' attribute to each observation.

Furthermore I added a private method to find the first numerical column in an Obs object that is used as a default for plotting and computing statistics.