ArtesiaWater / hydropandas

Module for loading observation data into custom DataFrames
https://hydropandas.readthedocs.io
MIT License
52 stars 11 forks source link

Read KNMI files locally #90

Closed martinvonk closed 11 months ago

martinvonk commented 1 year ago

I would like a feature where we can read KNMI observations (to an Obs(Collection)) from a local file. I know we already do this internally so it should not be that hard to implement right?

OnnoEbbens commented 1 year ago

Yeah good idea! The functions get_knmi_daily_rainfall_url and get_knmi_daily_meteo_url need to be modified slightly to allow this.

OnnoEbbens commented 1 year ago

some extra wishes:

OnnoEbbens commented 1 year ago

Another wish: merge the from_knmi, from_nearest_xy, from_obs and from_knmi_file to one single method. Move all the logic to the io_knmi module

martinvonk commented 1 year ago

Another wish: merge the from_knmi, from_nearest_xy, from_obs and from_knmi_file to one single method. Move all the logic to the io_knmi module

We could also rename from_knmi to from_station and let from_knmi autodetect whether the first argument is a tuple with x and y (call from_nearest_xy), is an int (call from_station), is a str (call from_kni_file) etc. Then we can also leave the other methods intact at this place?