search

ArtexJay / Obsidian-CyberGlow

A colorful unique theme, giving Obsidian a fresh new look with glow effects and support for accent color. The theme now tries to provide a unique futuristic eye-candy look to obsidian while keeping it usable and familiar to the users. Made to be yours to tweak.
MIT License
82 stars 6 forks source link

[Desktop Bug] Color Picker Previews in Style Settings Not Holding Colors #72

Open SuperDragonite2172 opened 8 months ago

SuperDragonite2172 commented 8 months ago

Describe the bug When editing the colors in the Color Picker dropdown in Style Settings, the color previews don't hold their color after closing and re-opening Style Settings. They all default to the hsla(170, 49%, 32%, 1) regardless of what they're actually set to.

To Reproduce Steps to reproduce the behavior:

  1. Open Style Settings in Options
  2. Change a color or apply the default
  3. Close the dropdown or options
  4. Observe the new colors taking effect
  5. Reopen the settings to find the colors preview "unchanged".

Expected behavior Color previews in Style Settings display the actual color not the default.

Screenshots, Gifs, Video 2024-02-18_1708302823 2024-02-18_1708302885

Desktop (please complete the following information):

Additional context The example screenshots show the headings specifically since they're the most obvious, but it applies to all the colors. Originally I thought the colors weren't applying correctly at all but in filing the issue I discovered it was just Style Settings not updating correctly. Apologies if there's any weirdness in the information provided as a result. Edit: It just occurred to me this might be an upstream issue with Style Settings rather than with the theme specifically. I don't have any other themes that utilize Style Settings so I can't verify.

ArtexJay commented 8 months ago

I am unable to reproduce this issue with default theme colors after I applied custom colors via Style Settings, I have closed style settings and even restarted Obsidian, with Style Setting still showing the correct saved color for headings when altered. Do they default to that hsla(170, 49%, 32%, 1) even with the default theme colors for you?

If you have modified my theme, backup the theme file so you don't lose your custom edits and redownload my theme, see if the issue persists.

SuperDragonite2172 commented 8 months ago

I uninstalled Cyber Glow and Style Settings, then re-installed both. I also updated Cyber Glow to 8.2.6. The issue persists and the displayed colors are still not correct until I reset them or click on the color to change it. Thankfully the only settings I really change are enabling the workspace background and hovering the status bar.

ArtexJay commented 8 months ago

that's very strange, I tried again today, but I cannot replicate this on my end, the colors display correct custom applied colors. image

This could be a Style Settings issue, but I really do not know.

My installer version is 1.5.3, with Obsidian at version 1.5.8, I'm assuming it's the same with you.

SuperDragonite2172 commented 8 months ago

I was on Obsidian 1.5.3. I just updated it to 1.5.8 and the issue still persists.

ArtexJay commented 3 weeks ago

Are you still seeing this issue in the latest version of CyberGlow v1.4.0?

SuperDragonite2172 commented 3 weeks ago

Yes, I'm still seeing the issue. I'm on Obsidian version 1.7.4, CyberGlow version 1.4.0, and Style Settings 1.0.9. The colors swatches still all show up as hsl(170, 49%, 32%) when I first open the settings and then correct themselves when I click on the swatch. See the screenshot below for what it looks like immediately after opening the settings.

First Appearance