search

Artheau / SpriteSomething

A GUI-enabled suite for management and replacement of retro gaming sprites. Most known for its ability to inject custom player graphics into Super Metroid and A Link to the Past. Get the latest version at https://github.com/Artheau/SpriteSomething/releases .
Other
21 stars 16 forks source link

fixing cli (was missing spiffy_dict) #125

Closed chriscauley closed 1 year ago

chriscauley commented 1 year ago

Hello, I'm trying to use Sprite Something in the command line and it looks like the cli is broken. If I checkout 777ca70 then everything works fine, but on master it breaks. The inject_into_ROM function had an extra argument added ("spiffy_dict") and the CLI interface was never updated.

After poking around for a few minutes I think I fixed it.

miketrethewey commented 1 year ago

After the checks finish, could you re-point this to stable instead of master? Thanks!

chriscauley commented 1 year ago

@miketrethewey the cli failed on a step so I pointed it against stable thinking that might fix it. It looks like you need to manually run the workflow though. Here's the step that failed and the command it failed on was git commit -q -F commit.txt

https://github.com/Artheau/SpriteSomething/actions/runs/3714443237/jobs/6299802022

miketrethewey commented 1 year ago

Yep. All that's expected. Thanks for repointing it. I have some maintenance to do to make master not targetable. So, my fault there. We're all for contributions to fix and enhance stuff. :3 I'll poke it soon.