search

Arthur-Milchior / anki-Multi-column-edit-window

Alllow the editor to have to have multiple columns
6 stars 2 forks source link

Make sure to return from original onBridgeCmd to preserve Python → JS bridge #5

Closed glutanimate closed 5 years ago

glutanimate commented 5 years ago

Hi Arthur,

I've been trying to resolve common add-on conflicts recently, and one of the key issues I've found were problems with the implementation of link handler / onBridgeCmd patches. The crux is that in Anki 2.1, the link handler and onBridgeCmd no longer only act as a one-way street between JS and Python, but can also pass return values from Python to JS via an optional pycmd callback (cf. https://github.com/dae/anki/pull/228 and https://github.com/dae/anki/commit/56e1643bfa0391c71d3323b7d12b77c9fa8af551).

Unfortunately this is not as obvious in Anki's source code as it probably should be (something I plan to file a PR for), and accordingly many add-ons do not return from their custom link handlers. As a result they interfere with other add-ons that do depend on this Python → JS bridge (e.g. Pop-up Dictionary).

So what I'm trying to do at the moment is to go through the add-ons in question and either file PRs to fix the problem, or notify the authors about the situation. Since I likely won't be able to catch all cases, I'd very much appreciate it if you could check and see if you can find any other add-ons that have the same problem.

Thanks a lot in advance!

Arthur-Milchior commented 5 years ago

Thank you for letting me know that this change occurred. It's quite interesting. I just checked all of the add-on of my folder, and onBridgeCmd is changed nowhere else. Add-on updated on ankiweb

glutanimate commented 5 years ago

Great, thanks for the quick response and for checking with your other add-ons! I really appreciate that.