search

Arthur-Milchior / anki-enhanced-cloze

GNU General Public License v3.0
2 stars 1 forks source link

edits in browser affect multiple cards #10

Open marcozer opened 5 years ago

marcozer commented 5 years ago

When editing in browser a field and then selecting an other card, it automatically copies the previous edited field to replace the first field of the selected card, not matter which note type it is. I lost many notes with this bug, which results in duplicates.

khonkhortisan commented 5 years ago

I'm seeing behavior slightly different, it doesn't have to be the first field. Every time a card is selected (including by click, Control+click, Shift+click, up, down, Control+up, Control+down, Shift+up, Shift+down, page up, etc.), the first card[ the one getting unselected if it's single selection, or the one selected first in a multi-select ]'s field [matching the last-edited field from the last-edited card] gets replaced with the text from the last edited field [unless nothing has been edited yet, in which case nothing different happens].

Arthur-Milchior commented 5 years ago

Oops, it seems I missed the first message. I'll take a look at it later

Does the problem occurs onky ok n the note type advanced clozes, or does it have the problem on every note type ?

khonkhortisan commented 5 years ago

I noticed the problem on the Basic note type, I haven't even tried using the addon (just had it installed) or its note type yet.

Arthur-Milchior commented 5 years ago

I can't reproduce the bug as you described it. Can you please tell me what other add-on you have installed. both of you. Because, right now, on anki 2.1.13, when I disable all add-ons but this one, it seems to work perfectly. Did you try updating the add-ons recently ?

Marcozer, do you know how to use back-ups ?  I should have asked earlier. But this would allow you to recover lost notes. I'm really sorry for this problem

khonkhortisan commented 5 years ago

Help→About→Copy Debug Info

Anki 2.1.13 (3ba55990) Python 3.6.7 Qt 5.12.1 PyQt 5.11.3
Platform: Windows 10
Flags: frz=True ao=True sv=2

Add-ons:

Extended Card Stats During Review
Edit Field During Review (desactivado)
Auto Markdown
Speed Focus Mode auto-alert auto-reveal auto-fail (desactivado)
Color Confirmation (desactivado)
Export Cards As Text V211 (desactivado)
AnkiDiscord - Discord integration for Anki (desactivado)
Edit cards template with python and a domain specific language (desactivado)
Pretzel Logic Retention Benchmarking
Convert Subdecks to Tag Hierarchy
HoochiePapa Randomize New Queue
Right Hand Reviews jkl
HTML Window source
Add Table
Field History (desactivado)
Korean Support
Image Occlusion Enhanced for Anki 21 alpha
Search and Replace Tags
Deck Stats
HoochieMama Randomize Rev Queue
Syntax Highlighting for Code
Another Retreat
Night Mode (desactivado)
Touch Wood Show New Cards Left Hint
Obtain a beautiful readable and debuggable database for anki
Move Stats and Sync buttons to the right
Full Screen Toggle (desactivado)
Touch Screen - draw and write on your cards
Refocus Card when Reviewing 21
Content Injector
MentalPause No bonus for being late
Search in Add Card Dialog
CrowdAnki JSON exportimport Edit history Collaborate on deck creation (desactivado)
Backup Key
MemoBeam
Rebuild All  Empty All for Anki 21
Stats Overview Pie Graph with Distinct Learning and-or Relearning Sections
Zoom 21 (desactivado)
HoochieBaby Queue Controller  Day-Lrn Q
 PUBLIC BETA Heisig RTK Rebooting the Kanji - Related Vocab on Sentence Cards (desactivado)
editor apply font color background color custom class custom style
Ignore accents in browser search
Fastbar another toolbar for Anki 21 beta
Export cards selected in the Browser (desactivado)
Add a tag to notes with missing media
AnkiConnect (desactivado)
Enhanced cloze 21 (desactivado)
Advanced note editor Multi-column Frozen fields
Anki Fanfare GamificationFeedback (desactivado)
LPCG LyricsPoetry Cloze Generator
Load Balanced Scheduler
Progress Bar
Chinese Companion - frequency sort HSK suspend heisig support and more
Highlight Search Results in the Browser
Progress Graphs and Stats for Learned and Matured Cards
Batch Editing
AnkiCollab (desactivado)
Add Hyperlink
Opening the same window multiple time
DrawingPad
Japanese Support
Ease Factor Histogram
Replay buttons on card
Add-on folder with readable names
Removes Empty Note Types for 21
Improved Quizlet to Anki 21 Importer
Fast cards reposition
Clean the default deck
Life Drain (desactivado)
More Overview Stats 21
Additional Card Fields - Fork for 21
3 add-ons merged quicker anki explain deletion explain database check (desactivado)
Echelon - Improved Hierarchical Tags for Anki 21
Chinese Support Redux
Create Filtered Deck from the Browser
Advanced Browser
Enhance main window
Slackers Delight PostponeDefer Button (desactivado)
Knockout Deck Subset Learning
MorphMan for Anki 21
Kanji Grid
maobi - Chinese Hanzi Writing Quizzes in Anki v0 3 0 (desactivado)
Incremental Reading v4103 (desactivado)
Anki Habitica formerly Anki HRPG (desactivado)
Quantified_Self_add-on_-_export_your_review_log_-_v02
Removes_Empty_Note_Types (desactivado)
anki-addon-glossary (desactivado)
anki-enhance-main-window (desactivado)
anki-quick-easy
awesometts-anki-addon
deadline (desactivado)
deck_name_in_title
gCalEventPush (desactivado)
main_fullscreen
remaining_time (desactivado)
review_heatmap
speed-focus-mode-v0

It's the worst-case scenario: Even disabling every other addon, it still has this problem.

khonkhortisan commented 5 years ago

Steps to reproduce: Disable all addons except this one, switch profile, add a testdummy profile, add cards (huh, enhanced cloze is the default option), switch note type image to basic, put card 1 in the first field, add card, do the same for card 2, card 3, etc (I made 9 of them), close that, open the browser, press enter, click on card 2, click in the first field, press backspace 2 (so it counts as an edit), click on card 3, click on card 4, see that card 3 changed to card 2.

Arthur-Milchior commented 5 years ago

I'm really sorry. I tried to follow the step, and I can't reproduce the bug. What do you mean by «press backspace 2». I pressed backspace on card 2, I assumed that it what you meant

ijgnd commented 5 years ago

I also at least once had the problem that note contents got copied over from one note to another one with older versions of this add-on.

Since this happened over two weeks ago I don't remember the details. But I'm pretty sure that the source of the problem was "Enhanced cloze" since I tested on the latest version of Anki and "Enhanced Cloze" was the only add-on that I had installed when I tested.

So far I couldn't reproduce this problem with the latest version from Ankiweb from 2019-07-04. I wonder if other people can still reproduce this problem after the update.

khonkhortisan commented 5 years ago

With an updated addon from ankiweb and Anki 2.1.14 and my other addons enabled it no longer copies text across cards. Hopefully it's fixed, but I'll be uneasy if the cause isn't found. worksformenow.

Ankilover commented 5 years ago

I had the same problem. I think it is because "Enhaced Main Windows" addon.

Arthur-Milchior commented 5 years ago

Why do you think that ? There is absolutely no reason for them to interact at all.

Le lun. 22 juil. 2019 à 21:24, Ankilover notifications@github.com a écrit :

I had the same problem. I think it is because "Enhaced Main Windows" addon.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Arthur-Milchior/anki-enhanced-cloze/issues/10?email_source=notifications&email_token=AACXH4I7XC76DHVCUANMTE3QAYCOBA5CNFSM4H24AZ5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2Q4WFQ#issuecomment-513919766, or mute the thread https://github.com/notifications/unsubscribe-auth/AACXH4JXLIGELSB3DR5VJ5TQAYCOBANCNFSM4H24AZ5A .

Ankilover commented 5 years ago

No, I thought that, but it was wrong. I uninstalled all the Addons I had and the problem continued. Now I downgrade to Anki 2.0 but if you want, I can make tests on 2.1. My English is poor but I think you can understand me, no? Thank you.

ijgnd commented 4 years ago

I think I have a fix for the browser problem in this pull request: https://github.com/Arthur-Milchior/anki-enhanced-cloze/pull/16

Could someone here test my commits? These need to be tested. But Arthur has said that he doesn't use the add-on so someone else will have to do the testing.

My fix is copying the solution from the recently released "Cloze hide All". The rest of my commits mainly tidy up the add-on, also see my comment on the pull request.

Ankilover commented 4 years ago

I think the problem is when we updated the cards in browser. I never more used the function "Updated Enhanced Cloze" in Edit menu, one Browser and never more had problems. Today I use a addon call "CTRLF5 to Refresch the Browser" It works! Sorry again for my English. image