Arthur-Milchior / anki-enhanced-cloze

GNU General Public License v3.0
2 stars 1 forks source link

edits in the browser are not saved #6

Closed ijgnd closed 5 years ago

ijgnd commented 5 years ago

at least in this situation: https://streamable.com/zzhvd

This was inspired by the one negative review on ankiweb. I think I can reproduce it, see the video. I made this video yesterday. and again I didn't quickly find a fix ...

ijgnd commented 5 years ago

I'm not sure if my prior post was clear: I have never left a negative review to complain about an error in any add-on without first raising an issue on github and waiting an appropriate time. In fact I have never left you a negative review. I just saw the negative review and decided to see if I could replicate it (which I could).

Thank you so much for dealing with this add-on.

I cloned 97aff30 and adjusted it as described in #8. Now the editing problem mostly disappeared.

Mostly because I have to wait a small time until before I can change the row. Otherwise the contents will be disregarded.

Also Ctrl+A seems to be affected: If I try without any add-ons and the focus is on the table all table rows are selected. If I add your add-on (and no other ones) and the focus is on the table Ctrl+A selects all the fields (contents and names) on the bottom: the whole editor component seems to be selected.

I tested on linux with 2.1.13 (from the official website).

Arthur-Milchior commented 5 years ago

Sorry, I didn't see the bug report. I don't know why. I have the same problem on my computer. It disappears if you select another field after editing. I believe I know why it occurs, but I'm not sure how to solve it. I think the add-on recompute the note before the editor has time to tell the add-on the note was edited. May be I'll just tell the add-on to wait for one second

ijgnd commented 5 years ago

Thanks for the update and fixing this problem: I can't reproduce it with the add-on version that you published last night on ankiweb on Anki 2.1.14 (linux).