search

Arthur151 / ROMP

Monocular, One-stage, Regression of Multiple 3D People and their 3D positions & trajectories in camera & global coordinates. ROMP[ICCV21], BEV[CVPR22], TRACE[CVPR2023]
https://www.yusun.work/
Apache License 2.0
1.35k stars 231 forks source link

'with_renderer' argument raises TypeError #215

Open uyoung-jeong opened 2 years ago

uyoung-jeong commented 2 years ago

I tried to test the dataset loading process as described in https://github.com/Arthur151/ROMP/blob/master/docs/dataset.md python -m romp.lib.dataset.lsp

It raised an error as below: visualizer = Visualizer(resolution = (512,512,3), result_img_dir=save_dir,with_renderer=True) TypeError: __init__() got an unexpected keyword argument 'with_renderer'

This error occured in the line https://github.com/Arthur151/ROMP/blob/7b4734270672e602f4fc5659d37479478e72b78b/romp/lib/dataset/image_base.py#L485

Initialization function of visualizer does not have such argument: https://github.com/Arthur151/ROMP/blob/7b4734270672e602f4fc5659d37479478e72b78b/romp/lib/visualization/visualization.py#L28

Is this an obsolete argument or did I miss something?

uyoung-jeong commented 2 years ago

I fixed the 485th line of image_base.py as below, and it works. visualizer = Visualizer(resolution = (512,512,3), result_img_dir=save_dir, renderer_type=args().renderer)