search

ArthurCose / Scriptable-OpenNetBattle-Server

An OpenNetBattle Server with Lua scripting support.
GNU General Public License v3.0
9 stars 7 forks source link

Not compatible with Tiled 1.9.0 #5

Open TheMaverickProgrammer opened 2 years ago

TheMaverickProgrammer commented 2 years ago

Last working minor version was Tiled 1.8.6

In the latest major version, Tiled changes map property type to class. Changelog: https://www.mapeditor.org/2022/06/25/tiled-1-9-released.html

ArthurCose commented 2 years ago

Is this still broken with the latest changes?

TheMaverickProgrammer commented 2 years ago

Not broken but I worry about the compatibility: https://github.com/mapeditor/tiled/issues/3406

Maybe best to leave this issue open until we can be sure there will be no problems with the hotfix.

eishiya commented 2 years ago

Tiled 1.9 can save 1.8-style maps and tilesets, you can set it to do so in your Project Properties, so until this is fixed, that's an option for users.

If you're planning to fix this by making "class" a synonym for "type", make sure you only do so for Objects and Tiles, and not for Custom Properties, which still use "type" (the value of which can be "class"...), and not for anything that didn't have classes/types before 1.9 (Layers, Maps, etc).

TheMaverickProgrammer commented 2 years ago

Recap: It is safe to make "class" and "type" synonyms, but only for Objects and Tiles, not for anything else (not for custom Properties, where "type" has its own meaning, and not Maps, Layers, Tilesets, Terrain Sets, Terrains, which have never had a "type" and now have "class").