ArthurG / Kijiji-Repost-Headless

Repost / Post Kijiji ads with Python
MIT License
144 stars 60 forks source link

Enhancement : used pushbullet for notification #133

Open Hatoris opened 5 years ago

Hatoris commented 5 years ago

First of all thank you for this really nice piece of soft, it's really well written and a pleasure to use.

I use your package on my server, with cron for scedulling repost of ads. I know that kijiji sends a email when ads is posted but I wanted something else to avoid recive to many emails.

I forked your repo and add pushbullet api to it. In this way I receive notification with ad title and informations about the post (succeed, failed, remove previous ads ...).

Are you interested that I pull my features in to your repo ?

ArthurG commented 5 years ago

Sorry for the late reply! I've been focused on other projects recently and haven't been too focused on this project.

I took a look at your repo and noticed that you had a clever implementation for dealing with inexact title matches during ad deletion, I think that is a very handy feature which doesn't add to the existing build/repost user flow. I think that could handle some edge cases. Could you please submit a PR for that into the repo 😃?

About your pushbullet feature, it seems like from the lack of comments on this issue that other people aren't too interested in that feature. I'd say we should keep that out because it adds an extra step to the already confusing flow on ad building. I need to reconsider how to make building ads more intuitive, at which point being able to use pushbullet would be very helpful.