ArthurHub / Android-Image-Cropper

Image Cropping Library for Android, optimized for Camera / Gallery.
Apache License 2.0
6.39k stars 1.36k forks source link

getContext might be null after using crop image for fragment #526

Open atul219 opened 6 years ago

atul219 commented 6 years ago

@Override public void onActivityResult(int requestCode, int resultCode, Intent data) { super.onActivityResult(requestCode, resultCode, data);

    if (requestCode == GALLERY_PIC && resultCode == RESULT_OK) {
        Uri imageUri = data.getData();

        // start cropping activity for pre-acquired image saved on the device
        CropImage.activity(imageUri)
                .setAspectRatio(1, 1)
                .start(getContext(), ProfileFragment.this);

Argument 'getContext()' might be null

        if (requestCode == CropImage.CROP_IMAGE_ACTIVITY_REQUEST_CODE) {

Condition 'requestCode == CropImage.CROP_IMAGE_ACTIVITY_REQUEST_CODE' is always 'false

            CropImage.ActivityResult result = CropImage.getActivityResult(data);
            if (resultCode == RESULT_OK) {  }

else if (requestCode == CropImage.CROP_IMAGE_ACTIVITY_RESULT_ERROR_CODE) { Exception error = result.getError(); Toast.makeText(getActivity() , "Error" + error , Toast.LENGTH_SHORT).show(); }

I am not able to upload an image to firebase database. I think it might be because of 2 warning

  1. Argument 'getContext()' might be null
  2. Condition 'requestCode == CropImage.CROP_IMAGE_ACTIVITY_REQUEST_CODE' is always 'false
tzaroon commented 6 years ago

getting the same issue. requestCode == CropImage.CROP_IMAGE_ACTIVITY_REQUEST_CODE

is always false

CropImage.activity(image) .setAspectRatio(1, 1) .start(context as Activity,this)

using the above crop in fragment.... kindly help me

tzaroon commented 6 years ago

issue solved for me 💯 by using the previous version implementation 'com.theartofdev.edmodo:android-image-cropper:2.6.+'