search

ArthurHub / Android-Image-Cropper

Image Cropping Library for Android, optimized for Camera / Gallery.
Apache License 2.0
6.38k stars 1.34k forks source link

2.8.0 requires project to use androidx #633

Open matthewkrueger opened 5 years ago

matthewkrueger commented 5 years ago

There is a bug/crash in version 2.7.0 that's affecting the production version of our app. I read that this bug was fixed in 2.8.0.

I have tried to update to the 2.8.0 version of Android-Image-Cropper, but it appears you switched to androidx, which would require my entire project to be upgraded to androidx. I cannot do that at this time, but the crash in the 2.7.0 image cropper code is causing big issues in production.

There is nothing in your documentation about requiring androidx to use this library. That's the first step - please update your docs as this took quite a while to narrow down.

Secondly, how can I get this library to work alongside other non-androidx projects?

manuelrego27 commented 5 years ago

+1 here

matthewkrueger commented 5 years ago

I love this library and all the work you've done on it, but forcing established apps to upgrade to androidx may not be the right call, especially since 2.8.0 included a critical bug fix that is NEEDED for Android Pie users to use the library without crashing. If there's a way to make it co-exist with the old support library, I think that would be a much better option. I can't imagine that most app developers can upgrade big apps to androidx yet.

Over the last week in production, we've had over 150 users experience a crash with the image cropper. If there is no easy solution, I'm going to have to fork this library, or switch to a different library. Thanks for your time to read and consider this.

MBEDOBE commented 5 years ago

i share your opinion @matthewkrueger. i was working on a project and had to pause because i traveled for some work. i tried continuing my project this morning and i'm still stuck with android manifest errors. upgrading my entire project to androidx will be difficult for now.

unludo commented 5 years ago

Hi, anyone with a workaround, just in case?

MBEDOBE commented 5 years ago

you can use the previous version though it's not as the latest version.

On Sun, 23 Dec 2018 21:28 unludo <notifications@github.com wrote:

Hi, anyone with a workaround, just in case?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ArthurHub/Android-Image-Cropper/issues/633#issuecomment-449664292, or mute the thread https://github.com/notifications/unsubscribe-auth/AYEtYJ-gWG8kVtc0-_reSH49uHTmXItRks5u7_WYgaJpZM4ZC47Z .

unludo commented 5 years ago

No, it's crashing on android pie, it's blocking.

MBEDOBE commented 5 years ago

that's true. with Android pie, the previous version crashes

On Sun, 23 Dec 2018 21:36 unludo <notifications@github.com wrote:

No, it's crashing on android pie, it's blocking.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ArthurHub/Android-Image-Cropper/issues/633#issuecomment-449664637, or mute the thread https://github.com/notifications/unsubscribe-auth/AYEtYBOoeDbj5nyesp8A8bGO5uu7dvJkks5u7_dJgaJpZM4ZC47Z .

svran commented 5 years ago

try: implementation 'com.github.svran:Android-Image-Cropper:2.8.0.4' i forked this project and change to "com.android.support" libary.

MBEDOBE commented 5 years ago

ok let me try it out. I'll get back to you😊

On Wed, 26 Dec 2018 09:30 LiulianRan <notifications@github.com wrote:

try: implementation 'com.github.svran:Android-Image-Cropper:2.8.0.2' i forked this project and change to "com.android.support" libary.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ArthurHub/Android-Image-Cropper/issues/633#issuecomment-449938025, or mute the thread https://github.com/notifications/unsubscribe-auth/AYEtYBnsGg9K_2AC7u00MQT7d3lvez5Lks5u80GpgaJpZM4ZC47Z .

MBEDOBE commented 5 years ago

sync failed: failed to resolve: 'com.github.svran:Android-Image-Cropper:2.8.0.2'

On Wed, 26 Dec 2018 09:30 LiulianRan <notifications@github.com wrote:

try: implementation 'com.github.svran:Android-Image-Cropper:2.8.0.2' i forked this project and change to "com.android.support" libary.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ArthurHub/Android-Image-Cropper/issues/633#issuecomment-449938025, or mute the thread https://github.com/notifications/unsubscribe-auth/AYEtYBnsGg9K_2AC7u00MQT7d3lvez5Lks5u80GpgaJpZM4ZC47Z .

svran commented 5 years ago

add this allprojects { repositories { jcenter() maven { url "https://jitpack.io" } } }

MBEDOBE commented 5 years ago

gradle synced successfully but using it in the app throws a build error: package com.thartofdev.edmodo.cropper does not exist. I think the problem lies in the import statement.

On Wed, 26 Dec 2018 09:44 LiulianRan <notifications@github.com wrote:

add this allprojects { repositories { jcenter() maven { url "https://jitpack.io" } } }

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ArthurHub/Android-Image-Cropper/issues/633#issuecomment-449940206, or mute the thread https://github.com/notifications/unsubscribe-auth/AYEtYLe_uI8dENtJUvkazeOWaD_Ab34uks5u80UWgaJpZM4ZC47Z .

svran commented 5 years ago

i only change androidX to support libary ，Did the original author modify the api?

MBEDOBE commented 5 years ago

no did you test it in an app?

On Wed, 26 Dec 2018 10:09 LiulianRan <notifications@github.com wrote:

i only change androidX to support libary ，Did the original author modify the api?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ArthurHub/Android-Image-Cropper/issues/633#issuecomment-449943659, or mute the thread https://github.com/notifications/unsubscribe-auth/AYEtYMIjPeHpOhKPp0h7zOUH9Yof5MV9ks5u80rxgaJpZM4ZC47Z .

MBEDOBE commented 5 years ago

this is what happens when gradle syncs successfully. image attached below.

On Wed, 26 Dec 2018 10:09 LiulianRan <notifications@github.com wrote:

i only change androidX to support libary ，Did the original author modify the api?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ArthurHub/Android-Image-Cropper/issues/633#issuecomment-449943659, or mute the thread https://github.com/notifications/unsubscribe-auth/AYEtYMIjPeHpOhKPp0h7zOUH9Yof5MV9ks5u80rxgaJpZM4ZC47Z .

svran commented 5 years ago

now try: implementation 'com.github.svran:Android-Image-Cropper:2.8.0.4' Sorry, I made a mistake in uploading the libary file.

MBEDOBE commented 5 years ago

yh it's working well now! gracias

On Wed, 26 Dec 2018 11:14 LiulianRan <notifications@github.com wrote:

now try: implementation 'com.github.svran:Android-Image-Cropper:2.8.0.4' Sorry, I made a mistake in uploading the libary file.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ArthurHub/Android-Image-Cropper/issues/633#issuecomment-449951581, or mute the thread https://github.com/notifications/unsubscribe-auth/AYEtYDNzC4JWfAWhTVwTNpRlZzar3sRuks5u81oFgaJpZM4ZC47Z .

dazeGitHub commented 5 years ago

now try: implementation 'com.github.svran:Android-Image-Cropper:2.8.0.4' Sorry, I made a mistake in uploading the libary file.

when I build , it need com.android.support:exifinterface:28.0.0,when I add api 'com.android.support:exifinterface:28.0.0', This bitch get this error :Unable to resolve dependency for ':app@releaseUnitTest/compileClasspath': Could not download exifinterface.aar, so how to reslove this ?

svran commented 5 years ago

now try: implementation 'com.github.svran:Android-Image-Cropper:2.8.0.4' Sorry, I made a mistake in uploading the libary file.

when I build , it need com.android.support:exifinterface:28.0.0,when I add api 'com.android.support:exifinterface:28.0.0', This bitch get this error :Unable to resolve dependency for ':app@releaseUnitTest/compileClasspath': Could not download exifinterface.aar, so how to reslove this ?

if only could not download ,add "google()" in your project build.gradle file. if exifinterface the version conflicts. use: implementation ( 'com.github.svran:Android-Image-Cropper:2.8.0.4' ) { exclude group: 'com.android.support' ,module: 'exifinterface'} And use the exifinterface version of your project. implementation 'com.android.support:exifinterface:your_project_support-libary_version'

raphaelbgr commented 5 years ago

Adding implementation com.github.svran:Android-Image-Cropper:2.8.0.4 solved the problem for me, thanks @svran

davidalonso commented 4 years ago

now try: implementation 'com.github.svran:Android-Image-Cropper:2.8.0.4' Sorry, I made a mistake in uploading the libary file.

Problem solved without migrating to AndroidX! Thanks @svran