ArthurHub / Android-Image-Cropper

Image Cropping Library for Android, optimized for Camera / Gallery.
Apache License 2.0
6.39k stars 1.36k forks source link

I discovered a bug from version 2.8.0 #641

Open ssowmoss opened 5 years ago

ssowmoss commented 5 years ago

Bug Manifest merger failed : Attribute application@appComponentFactory value=(android.support.v4.app.CoreComponentFactory) from [com.android.support:support-compat:28.0.0] AndroidManifest.xml:22:18-91

Yonkokilasi commented 5 years ago

Decided to use your library on kotlin to crop images. However On activity result(request code is not being called) in my fragment . This is my code :

when (requestCode) {
CropImage.CROP_IMAGE_ACTIVITY_REQUEST_CODE -> {
                    Log.e(TAG, "********************* crop request code")

                    val result = CropImage.getActivityResult(data)

                    when (resultCode) {
                        RESULT_OK -> {
                            imageUri = result.uri
                            Log.e(TAG, "********************* $imageUri")

                        }
                        CropImage.CROP_IMAGE_ACTIVITY_RESULT_ERROR_CODE -> Log.e(TAG, "********************* $result.error")
                        else -> Log.e(TAG, "********************* something went wrong $resultCode")
                    }
}
sanjeevkarat commented 5 years ago

@ssowmoss I face the same issue. Figured out that you have to use androidX to resolve the issue :( But unfortunately I can't upgrade to androidX yet cuz some of my other libraries depend on api 28.

BilalRabbani commented 5 years ago

following solution worked for me; using this library with Kotlin:

In build.gradle (Module: app) replace this: api 'com.theartofdev.edmodo:android-image-cropper:2.8.+' with this: api 'com.theartofdev.edmodo:android-image-cropper:2.7.0'

It may give you warning but works for me.

KarimRedaHassan commented 5 years ago

Same Issue here

atsezgi commented 5 years ago

Thanks so much @BilalRabbani, it worked me also.

Ktirumalsetty commented 4 years ago

ERROR: Unable to resolve dependency for ':app@debug/compileClasspath': Could not resolve com.theartofdev.edmodo:android-image-cropper:2.7.+.