search

ArthurKun21 / FGA-Preview

Donation would greatly help.
https://github.com/Fate-Grand-Automata/FGA
MIT License
1 stars 0 forks source link

Fix Command maker parsing error #199

Closed ArthurKun21 closed 1 month ago

ArthurKun21 commented 1 month ago

Fixes #198

ArthurKun21 commented 1 month ago
  1. Select either Next wave or Next turn in same wave
  2. Select a skill command
  3. Select another either Next wave or Next turn in same wave
  4. The skill command is lost.

HD-Player_vdWpwbqXPe

ArthurKun21 commented 1 month ago

Fix the error on https://github.com/ArthurKun21/FGA-Preview/pull/199#issuecomment-2210337573

But new error found

The turn/wave are not being respected

HD-Player_fzF4njLn0i

ArthurKun21 commented 1 month ago

Slightly fixed the https://github.com/ArthurKun21/FGA-Preview/pull/199#issuecomment-2221756549

firefox_9jZF0zo9TR

ArthurKun21 commented 1 month ago

Counting of wave is already fixed.

Bug: when adding a Next wave in same turn it causes the previous Next turn to have additional turn value while the Next turn would be on the Wave: 1 Turn 1

Technically, it has the correct value but the Wave 2 Turn 3 was given to the Next turn instead of the Next Wave

HD-Player_wg1udT3fDn