ArthurSonzogni / Diagon

Interactive ASCII art diagram generators. :star2:
https://arthursonzogni.com/Diagon/
MIT License
1.47k stars 56 forks source link

Removing label from sequence diagram connection causes browser crash #47

Open melink14 opened 1 year ago

melink14 commented 1 year ago

I started with the basic example and deleted the ':Hello Bob!' part of the first line.

After that, the graph stops rendering due to 'memory access out of bounds'

Refreshing fixes it.

ArthurSonzogni commented 1 year ago

Thank you! I will take a look, except if you want to find out yourself what's causing this?

melink14 commented 1 year ago

Thanks for looking.

On looking deeper, the stack trace I was seeing wasn't due to the freezing problem but instead appearing on inital load so it's probably a red herring.

Also, testing now on my home computer, I see that the rendering does freeze once you delete the : but starts working again once it's added back.

If the cause is just that you must have a label for connections then maybe this is just a small usability problem. I was confused when it stopped updating but it's minor!