search

ArthurSonzogni / ftxui-starter

A starter project using the FTXUI library
72 stars 16 forks source link

Always pull latest version of FTXUI #1

Closed Gecero closed 2 years ago

Gecero commented 2 years ago

This is easier than manually updating CMakeLists.txt for every version. I had great headaches figuring out why my code worked in the main repository but wouldn't using this template. It was due to cmake downloading an old version of FTXUI. I don't want other people to experience this too.

ArthurSonzogni commented 2 years ago

Hi @Gecero,

Thanks for this PR! Unfortunately, using an undefined version of FTXUI is a bad practice, because modifying FTXUI, like introducing breaking change would cause those project to break without updating those project. I used a commit hash to make others not to do this.

However, I am now using git tag. I believe we should land your patch, but specify the latest released version: v0.11