search

ArthurSonzogni / ftxui-starter

A starter project using the FTXUI library
72 stars 15 forks source link

Updated FTXUI version from 4.0.0 to 5.0.0 #6

Closed lesserfish closed 1 month ago

lesserfish commented 10 months ago

Currently, CMake fetches FTXUI's content from the 4.0.0 version of FTXUI.

Because of this, some of the examples provided in the main github repository of FTXUI won't work. (For example: examples/component/window.cpp will not work).

I've updated the GIT_TAG version from "v4.0.0" to "v5.0.0" to ensure that all examples work.

dacharyc commented 7 months ago

+1. I was coming here to make the same PR - bumping the version got me going with this example. It would be great if this could get merged.

ArthurSonzogni commented 1 month ago

Thanks you! Sorry for the late approval.

ArthurSonzogni commented 1 month ago

(It can be closed, because another PR did something similar)