Require C++17, bump FTXUI version to v5.0.0, minor tweaks.

ArthurSonzogni / ftxui-starter

A starter project using the FTXUI library

72 stars 16 forks source link

Require C++17, bump FTXUI version to v5.0.0, minor tweaks. #8

Closed ryouze closed 4 months ago

ryouze commented 4 months ago

I have made a couple of tweaks, mostly inspired by your json-tui project:

Increased the minimum required CMake version to 3.24.
Added global requirement for C++17 without compiler extensions.
Enabled verbose mode for FetchContent with GIT_PROGRESS.
Limited the download of FTXUI to only the most recent commit (GIT_SHALLOW) and excluded it from the build unless explicitly requested (EXCLUDE_FROM_ALL).
Replaced GetProperties and Populate with MakeAvailable.
Replaced quotes with angle brackets in main.cpp.
Removed void and std::endl from main.cpp.

After adding an install target, the program correctly runs from /usr/local/bin on macOS.

ArthurSonzogni commented 4 months ago

Thanks!

lochel commented 1 month ago

@ryouze Just curious, why was the minimum required CMake version bumped to 3.24? I didn’t have it available and 3.22 seemed to work fine for me. Do you think it could be lowered?

ryouze commented 1 month ago

@ryouze Just curious, why was the minimum required CMake version bumped to 3.24? I didn’t have it available and 3.22 seemed to work fine for me. Do you think it could be lowered?

To be honest, I didn’t put much thought into the version number. I chose 3.24 simply because that’s the version @ArthurSonzogni used in their project, json-tui. The version provided by my package manager (brew) is 3.30, so I didn’t run into any availability issues.

Upon further investigation, I realized that json-tui relies on the FIND_PACKAGE_ARGS NAMES <PACKAGE> syntax, which was introduced in CMake 3.24. However, since this template doesn’t actually use FIND_PACKAGE_ARGS, version 3.24 isn’t required. If version 3.22 works as expected, please submit a PR to lower it.