search

ArthurSonzogni / git-tui

Collection of human friendly terminal interface for git.
https://arthursonzogni.com
MIT License
138 stars 8 forks source link

Build fails to find installed ftxui #14

Closed yurivict closed 1 year ago

yurivict commented 1 year ago

It only tries to fetch it here for some reason.

I think the same is true for other projects using ftxui.

ArthurSonzogni commented 1 year ago

Hello,

It seems to work. See:

https://user-images.githubusercontent.com/4759106/211579783-e0905da9-1af4-420b-9d91-e7093c993852.mp4

Could you provide some instructions about how to reproduce the issue?

yurivict commented 1 year ago

The FreeBSD framework adds -DFETCHCONTENT_FULLY_DISCONNECTED:BOOL=ON to cmake args - this causes this failure.

But downloads aren't allowed during package build. Is there a reason that fetch is used instead of a simple find_package(ftxui)? Does it depend on a particular version of ftxui?

ArthurSonzogni commented 1 year ago

Do you know why: The FreeBSD framework adds -DFETCHCONTENT_FULLY_DISCONNECTED:BOOL=ON. I guess you would like packages to come from the OS package manager, instead of using cmake as a package manager.

git-tui depends currently on b56afce48ccd472cd2c3a53e619de0db1e7227a4, which is 5 patchs before HEAD, and 66 patch beyond the latest released.

I often develop FTXUI patches, to bring new improvement to git-tui, which make it unlikely to keep git-tui on past released versions. Ensuring this would either slow down git-tui development, or force FTXUI to release new version very often.

ArthurSonzogni commented 1 year ago

I tried building against an installed version of FTXUI, both the currently used one, and v3.0.0. Both worked, despite the breaking changes. There are only a few fixed bug that would be sad to miss.

yurivict commented 1 year ago

I guess you would like packages to come from the OS package manager, instead of using cmake as a package manager.

Downloads aren't allowed during package builds.

If you want to depend on some particular revision of ftxui git-submodule is the right way to do it.

ArthurSonzogni commented 1 year ago

@yurivict you can now use ftxui from the package installed on the system.

Same for the subprocess library, but I guess it isn't installable.