ArthurSonzogni / git-tui

Collection of human friendly terminal interface for git.
https://arthursonzogni.com
MIT License
125 stars 8 forks source link

Enhancement: provide a binary version for Windows #2

Open zosrothko opened 2 years ago

zosrothko commented 2 years ago

Hello

git-tui seems a very cool tool to check for difference between to snap of a git tree. However, it does not work on windows...

ArthurSonzogni commented 2 years ago

I will try to make github to automatically build the Windows and Mac binaries and get back to you.

ArthurSonzogni commented 2 years ago

@zosrothko, I am now automatically building Windows/Linux/Mac binaries after every releases. https://github.com/ArthurSonzogni/git-tui/releases/tag/v1.0.7

(See artefact)

I don't have any Windows or MacOS OS. Could you please try them for me?

If this doesn't work. It might be because this is invoking "git" instead of "git.exe" at the following location. Updating it in the following location: https://github.com/ArthurSonzogni/git-tui/search?l=C%2B%2B&q=ExecuteProcess might fix the potential problem.

jspraul commented 2 years ago

I got the following error in a pop-up (Ctrl+C then pasted below), I assume pretty standard for Go programs on Windows:

git-tui.exe - System Error The code execution cannot proceed because VCRUNTIME140_1.dll was not found. Reinstalling the program may fix this problem.

I downloaded and installed the latest supported Microsoft Visual C++ Redistributable from https://aka.ms/vs/16/release/vc_redist.x64.exe.

It works on my machine!

ArthurSonzogni commented 2 years ago

Thanks! Happy this worked for you.

About VisualStudio dynamic library, I believe next step is to link against it statically or compile with clang, so that other won't have to install it themselves. I think I am going to read: https://stackoverflow.com/questions/10113017/setting-the-msvc-runtime-in-cmake