search

ArthurSonzogni / git-tui

Collection of human friendly terminal interface for git.
https://arthursonzogni.com
MIT License
138 stars 8 forks source link

diff: Keep user's background color #9

Closed Finii closed 2 years ago

Finii commented 2 years ago

[why] The background in the main area is hardcoded to dark grey (30,30,30). This breaks the usability for people who have a light theme (i.e. black or dark text on light background).

[how] One solution would be to also change the foreground color, but that will for sure irritate people who use 'solarized' or other themes.

Imho it would be best not to tinker with the background colors unless at least light and dark is selectable as option (and ideally autoselect depending on the used terminal's current background (vim for example does that, adapt the color scheme to the current user selected background in the terminal).

So the solution implemented here is to completely drop the change in background color.

Screenshots

Here two sets of screenshots. tilix is used in a light theme, while terminal is set up for a dark theme.

Before PR

1

Background color in both terminals is the same, albeit tilix uses normally white and has black text while terminal uses black background and white text.

After PR

2

Background color not touched anymore. This means it's not dark-gray anymore but the default background color, that matches the used default foreground color.

ArthurSonzogni commented 2 years ago

Thanks! I believe this is a good change. Either we set both foreground and background colors or let the default. The middle ground isn't good.