search

ArthurSonzogni / json-tui

A JSON terminal UI made in C++
MIT License
334 stars 14 forks source link

Windows Support? #11

Closed TechStudent10 closed 2 years ago

TechStudent10 commented 2 years ago

Can I use this with Windows?

ArthurSonzogni commented 2 years ago

Not yet.

However, it shouldn't be that hard. We need to remove those lines: https://github.com/ArthurSonzogni/json-tui/blob/5a223aab989d7d46cd59e68c3c2dec7b7eea1168/src/main.cpp#L305-L307

It is to support:

program | json-tui

use case. We read first from the stdin which is initially piped connected to program output. After that, we read from the console.

I believe this is mostly a Unix concept. Do you know if something like this can be done on Windows? Maybe I can make Windows to skip this feature.

TechStudent10 commented 2 years ago

@ArthurSonzogni I do not understand 90% of that. I'm not a C++ Developer so I'm not sure. The only thing I got was that:

Not yet.

However, it shouldn't be that hard. We need to remove those lines:

https://github.com/ArthurSonzogni/json-tui/blob/5a223aab989d7d46cd59e68c3c2dec7b7eea1168/src/main.cpp#L305-L307

It is to support:

program | json-tui

use case. We read first from the stdin which is initially piped connected to program output. After that, we read from the console.

is a Unix concept and that something like this won't work on a WinNT system.

ArthurSonzogni commented 2 years ago

do not understand 90% of that.

TLDR: I can make it work Windows, one way or the other. I will make something soon. Today or tomorrow.

TechStudent10 commented 2 years ago

@ArthurSonzogni oh okay! Thanks!

ArthurSonzogni commented 2 years ago

Hi @TechStudent11 Windows should now be supported! Could you please take a look and tell me if there are any problems?

I don't have a WIndows OS, so I can't really test it myself. However the bot was able to build it a probduce a release: https://github.com/ArthurSonzogni/json-tui/releases/tag/v1.2.0

TechStudent10 commented 2 years ago

@ArthurSonzogni Woohoo! I'll test it out right now!

TechStudent10 commented 2 years ago

Proud to say that it works: image

ArthurSonzogni commented 2 years ago

Awesome! Thank you very much for checking!

TechStudent10 commented 2 years ago

Awesome! Thank you very much for checking!

No problem!

TechStudent10 commented 2 years ago

The fact that I just came back and now almost understand all of this:

Not yet.

However, it shouldn't be that hard. We need to remove those lines:

https://github.com/ArthurSonzogni/json-tui/blob/5a223aab989d7d46cd59e68c3c2dec7b7eea1168/src/main.cpp#L305-L307

It is to support:

program | json-tui

use case. We read first from the stdin which is initially piped connected to program output. After that, we read from the console.

I believe this is mostly a Unix concept. Do you know if something like this can be done on Windows? Maybe I can make Windows to skip this feature.