Cannot build with -fno-exceptions

ArthurSonzogni / json-tui

A JSON terminal UI made in C++

MIT License

334 stars 14 forks source link

Cannot build with -fno-exceptions #3

Closed hextriclosan closed 2 years ago

hextriclosan commented 2 years ago

$ cmake -DCMAKE_CXX_FLAGS="-fno-exceptions" . $ make :

[ 97%] Building CXX object CMakeFiles/json-tui.dir/src/main.cpp.o
/Users/igor/dev/json-tui/src/main.cpp:324:3: error: cannot use 'try' with exceptions disabled
  try {
  ^
1 error generated.
make[2]: *** [CMakeFiles/json-tui.dir/src/main.cpp.o] Error 1
make[1]: *** [CMakeFiles/json-tui.dir/all] Error 2
make: *** [all] Error 2

ArthurSonzogni commented 2 years ago

Indeed. Should we work to support "-fno-exception"?

hextriclosan commented 2 years ago

I think it's not an issue as long it's a standalone utility (not a library) and you don't support platforms that have no exceptions