search

ArthurSonzogni / json-tui

A JSON terminal UI made in C++
MIT License
334 stars 14 forks source link

Hitbox issue when not on top of the terminal window #7

Closed Drarig29 closed 2 years ago

Drarig29 commented 2 years ago

Sorry if I'm being annoying, but I found a hitbox bug. The video explains it all.

Basically, after I hit Ctrl+C and re-run the command, the hitboxes are shifted away from their real location.

I really think it's because the command isn't run from the top of the window.

Could someone test this in his terminal? Maybe the bug comes from my terminal emulator actually... I use https://github.com/kovidgoyal/kitty

Here is the example file I used: https://pastebin.com/HxCY0NUm

https://user-images.githubusercontent.com/9317502/148837469-363681d8-5379-42fb-a3ca-5758a5a61f3f.mp4

ArthurSonzogni commented 2 years ago

Thanks!

Yes, I observed it. I should update the underlying library to request a refresh of the position earlier.

ArthurSonzogni commented 2 years ago

I think I fixed it. Could you please check again whether this is working or not according to you? Don't forget to remove your build directory, in order to force fetching FTXUI again.

Drarig29 commented 2 years ago

Yup, it's fixed! You are reactive too! 😁

And thanks for the reminder to remove the build directory, I was going to say it didn't work ^^

ArthurSonzogni commented 2 years ago

And thanks for the reminder to remove the build directory, I was going to say it didn't work ^^ Haha, I edited my last response just in time then.

Thanks for your confirmation!