search

ArthurSonzogni / nlohmann_json_cmake_fetchcontent

A lightweight Release-tracking repository for nlohmann/json. Suitable for CMake fetchcontent. Automatically upgraded every weeks.
MIT License
79 stars 25 forks source link

Auto update using github actions #1

Closed Frago9876543210 closed 4 years ago

Frago9876543210 commented 4 years ago

PoC: (I removed that using rebase) img1 img2 but please note that it will happen again at 2020-06-28 00:00:00

ArthurSonzogni commented 4 years ago

Nice! Thank you! I will take a look during this weekend and merge it soon.

ArthurSonzogni commented 4 years ago

It took a look. This looks good! Thank you! +CC @nlohmann FYI

Frago9876543210 commented 4 years ago

Not sure how to upgrade readme. Only if specify master branch as "newest" version of json изображение

ArthurSonzogni commented 4 years ago

This looks like a good idea. I will try to find a way to make the README.md to self-modify itself to refer to the latest version.

Frago9876543210 commented 4 years ago

huh, but I suggest you create branch and set cron to 5 minutes or on push

nlohmann commented 4 years ago

Question is: why not use nlohmann/json directly? Is is still because FetchContent does not make a shallow checkout?

Frago9876543210 commented 4 years ago

@nlohmann it's size is about 200 megabytes (not sure about fetch content, but it does when repository X have json as submodule)

ArthurSonzogni commented 4 years ago

Is is still because FetchContent does not make a shallow checkout?

Isn't cmake already doing shallow clones? I think it does.

I just tried:

git clone --depth 1 https://github.com/nlohmann/json

I got 6.61 MiB download size, and 21MiB disk usage.

I just tried:

git clone --depth 1 https://github.com/ArthurSonzogni/nlohmann_json_cmake_fetchcontent

Dowload size is not displayed by git, and I have 1.4Mib disk usage.

ArthurSonzogni commented 4 years ago

I removed every tags, rebased from root and removed all the automated commits. I modified your github action so that the script will execute on the initial push.

I pushed, and the github action ran as expected: https://github.com/ArthurSonzogni/nlohmann_json_cmake_fetchcontent/runs/815751588?check_suite_focus=true

The git history is now rewritten using @actions-user as the committer. Perfect! https://github.com/ArthurSonzogni/nlohmann_json_cmake_fetchcontent/commits/master

This repository is now fully autonomous.