Fixes to threading, callbacks, receivers, etc.

ArthurVasseur / USB-Midi-Android-Plugin

A USB MIDI plugin for Android 6.0 and above

MIT License

9 stars 2 forks source link

Fixes to threading, callbacks, receivers, etc. #5

Closed trzy closed 1 year ago

trzy commented 1 year ago

Only a single BroadcastReceiver for USB events is now created. Previously, a new one was being created each time a USB device was attached (even if it was the same device being re-attached), causing an additional redundant onReceive() call each time a MIDI device was disconnected and then reconnected.
On device detachment, USB reader threads are stopped (although we do not actually join() them; seems to work ok for now).
The DeviceAttached callback will now fire if the device is already plugged in.
Added a RawMidi callback that fires on any MIDI data received and always before NoteOn/NoteOff.

ArthurVasseur commented 1 year ago

Thank you for your contribution :) Can you implement the function RawMidi the MyCallback class : https://github.com/ArthurVasseur/USB-Midi-Android-Plugin/blob/7ea827662a9ebf16173dc57bb01622066bb47fb0/exampleandroidapplication/src/main/java/com/arthaiirgames/exampleandroidapplication/MyCallback.java#L8

trzy commented 1 year ago

Done and I updated the README.md, too. Please give it a test on your devices. One thing in particular I had noticed on the Quest Pro is that the MIDI device had to be plugged in before the app started, otherwise a UsbReceiver wouldn't be created. Afterwards, disconnecting/re-connecting the device worked but produced resource duplication. However, if the app was started with the device unplugged, it would not be picked up. Now, it should work in both cases.

ArthurVasseur commented 1 year ago

Thank you again !