search

ArtifexSoftware / mupdf.js

JavaScript bindings for MuPDF
https://mupdfjs.readthedocs.io
GNU Affero General Public License v3.0
371 stars 22 forks source link

working react example #52

Closed Vilhelm-Ian closed 4 months ago

Vilhelm-Ian commented 5 months ago

Added some layout tips which should help.

The main thing though is - can we somehow reference what would exist in ../../dist for the libraries? We don't really want to duplicate this in public. If there is no way around it then update the README to inform the user about what they need to copy into "public".

I couldn't find a way to get it to work without copying every file from dist

jamie-lemon commented 5 months ago

@Vilhelm-Ian Looking at what you have done here - I think the force pushes might have messed up the branch - if I look at the graphical diffs, i.e.: https://github.com/ArtifexSoftware/mupdf.js/pull/52/files I see lots of changes outside of where you should be making changes - all changes for your PR should just be to examples/mupdf-react. I think it might be easier to abandon this PR and do a fresh one!